Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #38876 that excludes BlockManagerMessages.RegisterBlockManager in MiMa compatibility check.

Why are the changes needed?

It fails in MiMa check presumably with Scala 2.13 in other branches. Should be safer to exclude them all in the affected branches.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Filters copied from error messages. Will monitor the build in other branches.

Copy link
Member

@Ngone51 Ngone51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Dec 13, 2022

Merged to master, branch-3.3 and branch-3.2

HyukjinKwon added a commit that referenced this pull request Dec 13, 2022
…gisterBlockManager in MiMa

This PR is a followup of #38876 that excludes BlockManagerMessages.RegisterBlockManager in MiMa compatibility check.

It fails in MiMa check presumably with Scala 2.13 in other branches. Should be safer to exclude them all in the affected branches.

No, dev-only.

Filters copied from error messages. Will monitor the build in other branches.

Closes #39052 from HyukjinKwon/SPARK-41360-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit a2ceff2)
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon added a commit that referenced this pull request Dec 13, 2022
…gisterBlockManager in MiMa

This PR is a followup of #38876 that excludes BlockManagerMessages.RegisterBlockManager in MiMa compatibility check.

It fails in MiMa check presumably with Scala 2.13 in other branches. Should be safer to exclude them all in the affected branches.

No, dev-only.

Filters copied from error messages. Will monitor the build in other branches.

Closes #39052 from HyukjinKwon/SPARK-41360-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit a2ceff2)
Signed-off-by: Hyukjin Kwon <[email protected]>
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you!

@mridulm
Copy link
Contributor

mridulm commented Dec 13, 2022

Thanks @HyukjinKwon !

beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
…gisterBlockManager in MiMa

### What changes were proposed in this pull request?

This PR is a followup of apache#38876 that excludes BlockManagerMessages.RegisterBlockManager in MiMa compatibility check.

### Why are the changes needed?

It fails in MiMa check presumably with Scala 2.13 in other branches. Should be safer to exclude them all in the affected branches.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Filters copied from error messages. Will monitor the build in other branches.

Closes apache#39052 from HyukjinKwon/SPARK-41360-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
…gisterBlockManager in MiMa

This PR is a followup of apache#38876 that excludes BlockManagerMessages.RegisterBlockManager in MiMa compatibility check.

It fails in MiMa check presumably with Scala 2.13 in other branches. Should be safer to exclude them all in the affected branches.

No, dev-only.

Filters copied from error messages. Will monitor the build in other branches.

Closes apache#39052 from HyukjinKwon/SPARK-41360-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit a2ceff2)
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon HyukjinKwon deleted the SPARK-41360-followup branch January 15, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants