[SPARK-41485][BUILD][CORE][CONNECT][PROTOBUF] Unify the environment variable of *_PROTOC_EXEC_PATH. #39036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable of *_PROTOC_EXEC_PATH.
Member
|
Merged to master. |
Author
|
Thanks @HyukjinKwon @LuciferYang ~ |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…ariable of *_PROTOC_EXEC_PATH ### What changes were proposed in this pull request? This PR unify the environment variable of `*_PROTOC_EXEC_PATH` to support that users can use the same environment variable to build and test `core`, `connect`, `protobuf` module by use profile named `-Puser-defined-protoc` with specifying custom `protoc` executables. ### Why are the changes needed? As described in [SPARK-41485](https://issues.apache.org/jira/browse/SPARK-41485), at present, there are 3 similar environment variable of `*_PROTOC_EXEC_PATH`, but they use the same `pb` version. Because they are consistent in compilation, so I unify the environment variable names to simplify. ### Does this PR introduce _any_ user-facing change? No, the way to using official pre-release `protoc` binary files is activated by default. ### How was this patch tested? - Pass GitHub Actions - Manual test on CentOS6u3 and CentOS7u4 ```bash export SPARK_PROTOC_EXEC_PATH=/path-to-protoc-exe ./build/mvn clean install -pl core -Puser-defined-protoc -am -DskipTests -DskipDefaultProtoc ./build/mvn clean install -pl connector/connect/common -Puser-defined-protoc -am -DskipTests ./build/mvn clean install -pl connector/protobuf -Puser-defined-protoc -am -DskipTests ./build/mvn clean test -pl core -Puser-defined-protoc -DskipDefaultProtoc ./build/mvn clean test -pl connector/connect/common -Puser-defined-protoc ./build/mvn clean test -pl connector/protobuf -Puser-defined-protoc ``` and ```bash export SPARK_PROTOC_EXEC_PATH=/path-to-protoc-exe ./build/sbt clean "core/compile" -Puser-defined-protoc ./build/sbt clean "connect-common/compile" -Puser-defined-protoc ./build/sbt clean "protobuf/compile" -Puser-defined-protoc ./build/sbt "core/test" -Puser-defined-protoc ./build/sbt "connect-common/test" -Puser-defined-protoc ./build/sbt "protobuf/test" -Puser-defined-protoc ``` Closes apache#39036 from WolverineJiang/master. Authored-by: jianghaonan <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Contributor
|
The correct jira should be SPARK-41485 rather than SPARK-41461, please correct the pr title on this page, although the commit message cannot be changed. @WolverineJiang |
WolverineJiang
changed the title
Author
Done. I'll pay attention next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR unify the environment variable of
*_PROTOC_EXEC_PATHto support that users can use the same environment variable to build and testcore,connect,protobufmodule by use profile named-Puser-defined-protocwith specifying customprotocexecutables.Why are the changes needed?
As described in SPARK-41485, at present, there are 3 similar environment variable of
*_PROTOC_EXEC_PATH, but they use the samepbversion. Because they are consistent in compilation, so I unify the environment variable names to simplify.Does this PR introduce any user-facing change?
No, the way to using official pre-release
protocbinary files is activated by default.How was this patch tested?
and