[SPARK-41378][SQL][FOLLOWUP] DS V2 ColStats follow up #39027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failure doesn't seem to be related to my changes. |
cloud-fan
approved these changes
Dec 12, 2022
Contributor
|
thanks, merging to master! |
Contributor
Author
|
Thanks |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? follow-up PR ### Why are the changes needed? to address comments apache#38904 (comment) apache#38904 (comment) ### Does this PR introduce _any_ user-facing change? Change the return type of `columnStats()` from `Optional<Map>` to `Map`. ### How was this patch tested? existing test Closes apache#39027 from huaxingao/colstats_followup. Authored-by: huaxingao <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
follow-up PR
Why are the changes needed?
to address comments
#38904 (comment)
#38904 (comment)
Does this PR introduce any user-facing change?
Change the return type of
columnStats()fromOptional<Map>toMap.How was this patch tested?
existing test