[SPARK-41481][CORE][SQL] Reuse INVALID_TYPED_LITERAL instead of _LEGACY_ERROR_TEMP_0020
#39025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
INVALID_TYPED_LITERAL instead of _LEGACY_ERROR_TEMP_1020INVALID_TYPED_LITERAL instead of _LEGACY_ERROR_TEMP_0020
LuciferYang
commented
Dec 12, 2022
| } catch { | ||
| case e: IllegalArgumentException => | ||
| val ex = QueryParsingErrors.cannotParseIntervalValueError(value, ctx) | ||
| val ex = QueryParsingErrors.cannotParseValueTypeError(valueType, value, ctx) |
Contributor
Author
There was a problem hiding this comment.
@MaxGekk do you think the valueType use INTERVAL is OK?
MaxGekk
approved these changes
Dec 12, 2022
| } catch { | ||
| case e: IllegalArgumentException => | ||
| val ex = QueryParsingErrors.cannotParseIntervalValueError(value, ctx) | ||
| val ex = QueryParsingErrors.cannotParseValueTypeError(valueType, value, ctx) |
Member
|
@LuciferYang Is it ready? |
Contributor
Author
|
ready now |
Member
|
+1, LGTM. Merging to master. |
Contributor
Author
|
Thanks @MaxGekk |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…EGACY_ERROR_TEMP_0020` ### What changes were proposed in this pull request? This pr aims to reuse error class `INVALID_TYPED_LITERAL` instead of `_LEGACY_ERROR_TEMP_1020`. ### Why are the changes needed? Proper names of error classes to improve user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass Github Actions. Closes apache#39025 from LuciferYang/SPARK-41481. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to reuse error class
INVALID_TYPED_LITERALinstead of_LEGACY_ERROR_TEMP_1020.Why are the changes needed?
Proper names of error classes to improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions.