[SPARK-41478][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1234 #39018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
Dec 12, 2022
| }, | ||
| "ANALYZE_TABLE_VIEW_NOT_CACHED" : { | ||
| "message" : [ | ||
| "Temporary view <tableName> is not cached for analyzing columns." |
Member
There was a problem hiding this comment.
Could you improve the error message by following the common structure as in other errors in error-classes.json:
- State the issue
- Give a suggestion how to solve it.
The error could be:
Suggested change
| "Temporary view <tableName> is not cached for analyzing columns." | |
| "The ANALYZE TABLE FOR COLUMNS command can operate on temporary views that have been cached already. Consider to cache the view <viewName>." |
| "AES-<mode> with the padding <padding> by the <functionName> function." | ||
| ] | ||
| }, | ||
| "ANALYZE_TABLE_VIEW_NOT_CACHED" : { |
Member
There was a problem hiding this comment.
Suggested change
| "ANALYZE_TABLE_VIEW_NOT_CACHED" : { | |
| "ANALYZE_UNCACHED_TEMP_VIEW" : { |
|
Can one of the admins verify this patch? |
MaxGekk
approved these changes
Dec 13, 2022
Member
|
+1, LGTM. Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…P_1234 ### What changes were proposed in this pull request? In the PR, I propose to assign the name ANALYZE_UNCACHED_TEMP_VIEW to the error class _LEGACY_ERROR_TEMP_1234. ### Why are the changes needed? Proper names of error classes should improve user experience with Spark SQL. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add new UT. Pass GA. Closes apache#39018 from panbingkun/LEGACY_ERROR_TEMP_1234. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to assign the name ANALYZE_UNCACHED_TEMP_VIEW to the error class _LEGACY_ERROR_TEMP_1234.
Why are the changes needed?
Proper names of error classes should improve user experience with Spark SQL.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add new UT.
Pass GA.