[SPARK-41435][SQL] Change to call invalidFunctionArgumentsError for curdate() when expressions is not empty
#38960
Conversation
LuciferYang
changed the title
curdate() throw WRONG_NUM_ARGS when args is not nullcurdate() throw WRONG_NUM_ARGS when args is not empty
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
Could you remove the error class https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala#L654 and return an internal error instead of it.
|
There are two questions:
If necessary, I think remove the error class and returning an internal error should be completed in #38940. |
| } else { | ||
| throw QueryCompilationErrors.invalidFunctionArgumentNumberError( | ||
| Seq.empty, funcName, expressions.length) | ||
| Seq(0), funcName, expressions.length) |
There was a problem hiding this comment.
To clarify the intention of this pr, I will change this as
throw QueryCompilationErrors.invalidFunctionArgumentsError(funcName, "0", expressions.length)and update pr description later
LuciferYang
changed the title
curdate() throw WRONG_NUM_ARGS when args is not emptyinvalidFunctionArgumentsError for curdate() when expressions is not empty
|
+1, LGTM. Merging to master. |
|
Thanks @MaxGekk |
… `curdate()` when `expressions` is not empty ### What changes were proposed in this pull request? This pr change to call `invalidFunctionArgumentsError` instead of `invalidFunctionArgumentNumberError ` for `curdate()` when `expressions` is not empty, then `curdate()` will throw `AnalysisException` with error class `WRONG_NUM_ARGS` when input args it not empty. ### Why are the changes needed? `WRONG_NUM_ARGS` is a more appropriate error class ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add new test case Closes apache#38960 from LuciferYang/curdate-err-msg. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
2 participants
What changes were proposed in this pull request?
This pr change to call
invalidFunctionArgumentsErrorinstead ofinvalidFunctionArgumentNumberErrorforcurdate()whenexpressionsis not empty, thencurdate()will throwAnalysisExceptionwith error classWRONG_NUM_ARGSwhen input args it not empty.Why are the changes needed?
WRONG_NUM_ARGSis a more appropriate error classDoes this PR introduce any user-facing change?
No
How was this patch tested?
Add new test case