Skip to content

[SPARK-41376][CORE] Correct the Netty preferDirectBufs check logic on executor start #38901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pan3793 wants to merge 4 commits into from
Closed

[SPARK-41376][CORE] Correct the Netty preferDirectBufs check logic on executor start #38901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9def9fc
[SPARK-41376][CORE] Executor netty direct memory check should respect…
pan3793 Dec 4, 2022
91515df
address
pan3793 Dec 5, 2022
5fc5080
address comment
pan3793 Dec 7, 2022
e1198f4
nit
pan3793 Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,18 @@ public static PooledByteBufAllocator createPooledByteBufAllocator(
allowCache ? PooledByteBufAllocator.defaultUseCacheForAllThreads() : false
);
}

/**
* ByteBuf allocator prefers to allocate direct ByteBuf iif both Spark allows to create direct
* ByteBuf and Netty enables directBufferPreferred.
*/
public static boolean preferDirectBufs(TransportConf conf) {
boolean allowDirectBufs;
if (conf.sharedByteBufAllocators()) {
allowDirectBufs = conf.preferDirectBufsForSharedByteBufAllocators();
} else {
allowDirectBufs = conf.preferDirectBufs();
}
return allowDirectBufs && PlatformDependent.directBufferPreferred();
}
}
5 changes: 4 additions & 1 deletion core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ import org.apache.spark.deploy.SparkHadoopUtil
import org.apache.spark.deploy.worker.WorkerWatcher
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config._
import org.apache.spark.network.netty.SparkTransportConf
import org.apache.spark.network.util.NettyUtils
import org.apache.spark.resource.ResourceInformation
import org.apache.spark.resource.ResourceProfile
import org.apache.spark.resource.ResourceProfile._
Expand Down Expand Up @@ -85,7 +87,8 @@ private[spark] class CoarseGrainedExecutorBackend(

logInfo("Connecting to driver: " + driverUrl)
try {
if (PlatformDependent.directBufferPreferred() &&
val shuffleClientTransportConf = SparkTransportConf.fromSparkConf(env.conf, "shuffle")
if (NettyUtils.preferDirectBufs(shuffleClientTransportConf) &&
PlatformDependent.maxDirectMemory() < env.conf.get(MAX_REMOTE_BLOCK_SIZE_FETCH_TO_MEM)) {
throw new SparkException(s"Netty direct memory should at least be bigger than " +
s"'${MAX_REMOTE_BLOCK_SIZE_FETCH_TO_MEM.key}', but got " +
Expand Down