[SPARK-41249][SS][TEST] Add acceptance test for self-union on streaming query #38785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
viirya
changed the title
viirya
reviewed
Nov 24, 2022
| val unionedDf = streamDf.union(streamDf) | ||
|
|
||
| testStream(unionedDf) ( | ||
| AddData(stream, 1, 2, 3), |
Member
There was a problem hiding this comment.
If the data is written into the table location, instead of through the stream (i.e. like self-union, DSv1, read via table API), is it also working?
Contributor
Author
There was a problem hiding this comment.
I think so - here we also read from table via table API. (We use readStream.table.) It's just that the table is backed by MemoryStream.
viirya
approved these changes
Nov 24, 2022
Contributor
Author
|
Thanks! Merging to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…ng query ### What changes were proposed in this pull request? This PR proposes to add a new test suite specifically for self-union tests on streaming query. The test cases are acceptance tests for 4 different cases, DSv1 vs DSv2 / DataStreamReader API vs table API. ### Why are the changes needed? This PR brings more test coverage on streaming workloads. We should have caught an issue during the work of [SPARK-39564](https://issues.apache.org/jira/browse/SPARK-39564) if we had this test suite. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New test suite. Closes apache#38785 from HeartSaVioR/SPARK-41249. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…ng query ### What changes were proposed in this pull request? This PR proposes to add a new test suite specifically for self-union tests on streaming query. The test cases are acceptance tests for 4 different cases, DSv1 vs DSv2 / DataStreamReader API vs table API. ### Why are the changes needed? This PR brings more test coverage on streaming workloads. We should have caught an issue during the work of [SPARK-39564](https://issues.apache.org/jira/browse/SPARK-39564) if we had this test suite. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New test suite. Closes apache#38785 from HeartSaVioR/SPARK-41249. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add a new test suite specifically for self-union tests on streaming query. The test cases are acceptance tests for 4 different cases, DSv1 vs DSv2 / DataStreamReader API vs table API.
Why are the changes needed?
This PR brings more test coverage on streaming workloads. We should have caught an issue during the work of SPARK-39564 if we had this test suite.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New test suite.