[SPARK-41243][CONNECT][PYTHON][DOCS] Update the protobuf version in README #38775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
changed the title
Member
Author
|
@zhengruifeng @amaliujia @HyukjinKwon @grundprinzip Would you please take a look? |
amaliujia
reviewed
Nov 23, 2022
Contributor
amaliujia
left a comment
amaliujia
left a comment
There was a problem hiding this comment.
LGTM
Thanks for catching this!
Contributor
|
merged into master |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…EADME ### What changes were proposed in this pull request? Update the protobuf version to be `3.19.3` in README. ### Why are the changes needed? Since we have homogenized the protobuf version across server and client to be `3.19.3`, we should update the README to be consistent. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#38775 from xinrong-meng/new_readme. Authored-by: Xinrong Meng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…EADME ### What changes were proposed in this pull request? Update the protobuf version to be `3.19.3` in README. ### Why are the changes needed? Since we have homogenized the protobuf version across server and client to be `3.19.3`, we should update the README to be consistent. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests. Closes apache#38775 from xinrong-meng/new_readme. Authored-by: Xinrong Meng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the protobuf version to be
3.19.3in README.Why are the changes needed?
Since we have homogenized the protobuf version across server and client to be
3.19.3, we should update the README to be consistent.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.