Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Nov 23, 2022

What changes were proposed in this pull request?

This PR proposes to correct the minor syntax on error message for UNEXPECTED_INPUT_TYPE,

Why are the changes needed?

Error message should be started with upper-case character, and clear to read.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*”

@github-actions github-actions bot added the CORE label Nov 23, 2022
@itholic
Copy link
Contributor Author

itholic commented Nov 23, 2022

I made it into a separate PR from my other tasks although it's very small change, to avoid in case this error message change affecting the tests on the original PR which is unrelated to UNEXPECTED_INPUT_TYPE .

@MaxGekk MaxGekk closed this in 57f3f0f Nov 24, 2022
@MaxGekk
Copy link
Member

MaxGekk commented Nov 24, 2022

+1, LGTM. Merged to master.
Thank you, @itholic.

beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 15, 2022
### What changes were proposed in this pull request?

This PR proposes to correct the minor syntax on error message for `UNEXPECTED_INPUT_TYPE`,

### Why are the changes needed?

Error message should be started with upper-case character, and clear to read.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

```
./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*”
```

Closes apache#38766 from itholic/minor-UNEXPECTED_INPUT_TYPE.

Lead-authored-by: itholic <[email protected]>
Co-authored-by: Haejoon Lee <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
### What changes were proposed in this pull request?

This PR proposes to correct the minor syntax on error message for `UNEXPECTED_INPUT_TYPE`,

### Why are the changes needed?

Error message should be started with upper-case character, and clear to read.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

```
./build/sbt “sql/testOnly org.apache.spark.sql.SQLQueryTestSuite*”
```

Closes apache#38766 from itholic/minor-UNEXPECTED_INPUT_TYPE.

Lead-authored-by: itholic <[email protected]>
Co-authored-by: Haejoon Lee <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
@itholic itholic deleted the minor-UNEXPECTED_INPUT_TYPE branch April 22, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants