[SPARK-41206][SQL][FOLLOWUP] Make result of checkColumnNameDuplication stable to fix COLUMN_ALREADY_EXISTS check failed with Scala 2.13
#38764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
checkColumnNameDuplication stable to fix COLUMN_ALREADY_EXISTS check with Scala 2.13 checkColumnNameDuplication stable to fix COLUMN_ALREADY_EXISTS check fail with Scala 2.13
LuciferYang
changed the title
checkColumnNameDuplication stable to fix COLUMN_ALREADY_EXISTS check fail with Scala 2.13 checkColumnNameDuplication stable to fix COLUMN_ALREADY_EXISTS check failed with Scala 2.13
Contributor
Author
|
cc @HyukjinKwon try to fix #38685 (comment) Let us waiting CI |
HyukjinKwon
approved these changes
Nov 23, 2022
MaxGekk
approved these changes
Nov 23, 2022
Member
|
+1, LGTM. Merging to master. All GAs passed. |
Contributor
Author
|
Thanks @HyukjinKwon @MaxGekk |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…on` stable to fix `COLUMN_ALREADY_EXISTS` check failed with Scala 2.13 ### What changes were proposed in this pull request? This pr add a sort when `columnAlreadyExistsError` will be thrown to make the result of `SchemaUtils#checkColumnNameDuplication` stable. ### Why are the changes needed? Fix `COLUMN_ALREADY_EXISTS` check failed with Scala 2.13 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GA - Manual test: ``` dev/change-scala-version.sh 2.13 build/sbt clean "sql/testOnly org.apache.spark.sql.DataFrameSuite" -Pscala-2.13 build/sbt "sql/testOnly org.apache.spark.sql.execution.datasources.json.JsonV1Suite" -Pscala-2.13 build/sbt "sql/testOnly org.apache.spark.sql.execution.datasources.json.JsonV2Suite" -Pscala-2.13 build/sbt "sql/testOnly org.apache.spark.sql.execution.datasources.json.JsonLegacyTimeParserSuite" -Pscala-2.13 ``` All tests passed Closes apache#38764 from LuciferYang/SPARK-41206. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…on` stable to fix `COLUMN_ALREADY_EXISTS` check failed with Scala 2.13 ### What changes were proposed in this pull request? This pr add a sort when `columnAlreadyExistsError` will be thrown to make the result of `SchemaUtils#checkColumnNameDuplication` stable. ### Why are the changes needed? Fix `COLUMN_ALREADY_EXISTS` check failed with Scala 2.13 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GA - Manual test: ``` dev/change-scala-version.sh 2.13 build/sbt clean "sql/testOnly org.apache.spark.sql.DataFrameSuite" -Pscala-2.13 build/sbt "sql/testOnly org.apache.spark.sql.execution.datasources.json.JsonV1Suite" -Pscala-2.13 build/sbt "sql/testOnly org.apache.spark.sql.execution.datasources.json.JsonV2Suite" -Pscala-2.13 build/sbt "sql/testOnly org.apache.spark.sql.execution.datasources.json.JsonLegacyTimeParserSuite" -Pscala-2.13 ``` All tests passed Closes apache#38764 from LuciferYang/SPARK-41206. Authored-by: yangjie01 <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr add a sort when
columnAlreadyExistsErrorwill be thrown to make the result ofSchemaUtils#checkColumnNameDuplicationstable.Why are the changes needed?
Fix
COLUMN_ALREADY_EXISTScheck failed with Scala 2.13Does this PR introduce any user-facing change?
No
How was this patch tested?
All tests passed