[SPARK-41224][SPARK-41165][SPARK-41184] Optimized Arrow-based collect implementation to stream from server to client #38759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
SPARK-41165-followup
branch
from
f627257 to
1f5f6d9
Compare
HyukjinKwon
force-pushed
the
SPARK-41165-followup
branch
from
1f5f6d9 to
e2b4058
Compare
hvanhovell
reviewed
Nov 22, 2022
.../connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala
Outdated
Show resolved
Hide resolved
hvanhovell
reviewed
Nov 23, 2022
.../connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
force-pushed
the
SPARK-41165-followup
branch
3 times, most recently
from
c5d06ae to
972230f
Compare
HyukjinKwon
force-pushed
the
SPARK-41165-followup
branch
from
972230f to
e6faaa6
Compare
hvanhovell
approved these changes
Nov 24, 2022
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - thanks for picking this up
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
… implementation to stream from server to client ### What changes were proposed in this pull request? This PR proposes an optimized Arrow-based collect, that is virtually apache#38720 that implements the logics except a couple of nits. ### Why are the changes needed? To stream the Arrow batch from the server to the client side instead of waiting all the jobs to finish. ### Does this PR introduce _any_ user-facing change? No, this feature isn't released yet. ### How was this patch tested? Unittest added. Closes apache#38720 Closes apache#38759 from HyukjinKwon/SPARK-41165-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Herman van Hovell <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
… implementation to stream from server to client ### What changes were proposed in this pull request? This PR proposes an optimized Arrow-based collect, that is virtually apache#38720 that implements the logics except a couple of nits. ### Why are the changes needed? To stream the Arrow batch from the server to the client side instead of waiting all the jobs to finish. ### Does this PR introduce _any_ user-facing change? No, this feature isn't released yet. ### How was this patch tested? Unittest added. Closes apache#38720 Closes apache#38759 from HyukjinKwon/SPARK-41165-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes an optimized Arrow-based collect, that is virtually #38720 that implements the logics except a couple of nits.
Why are the changes needed?
To stream the Arrow batch from the server to the client side instead of waiting all the jobs to finish.
Does this PR introduce any user-facing change?
No, this feature isn't released yet.
How was this patch tested?
Unittest added.
Closes #38720