[SPARK-41221][SQL] Add the error class INVALID_FORMAT
#38755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
INVALID_FORMATINVALID_FORMAT
Member
Author
|
@srielau @srielau @itholic @panbingkun @LuciferYang Could you have a look at this PR, please. |
srielau
approved these changes
Nov 22, 2022
| ], | ||
| "sqlState" : "42000" | ||
| }, | ||
| "INVALID_FORMAT" : { |
Contributor
There was a problem hiding this comment.
Do we want this to be generic or specific to numbers.
I'm specifically wondering about DATE FORMAT, INTERVAL FORMAT, .. What have we/will we do with these?
Contributor
There was a problem hiding this comment.
Basically: Should we use INVALID_NUMBER_FORMAT, INVALID_DATETIME_FROMAT, .... or just this and bring them all in?
Member
Author
There was a problem hiding this comment.
Do we want this to be generic or specific to numbers.
I want to believe that we can make it as a generic error class. I have already merged LIKE ... errors into it.
I think there is the common part where we declare that the format is invalid and show it.
cloud-fan
approved these changes
Nov 23, 2022
Member
Author
|
Merging to master. Thank you, @srielau @cloud-fan @LuciferYang for review. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? In the PR, I propose to move out the error sub-classes related to number format issues from `DATATYPE_MISMATCH` to their own error class `INVALID_FORMAT`. Also, the PR deletes the error class `INVALID_LIKE_PATTERN`, and moves their sub-classes to `INVALID_FORMAT`. ### Why are the changes needed? To improve usability of Spark SQL and to don't confuse users by error class names related to values but to to its types. ### Does this PR introduce _any_ user-facing change? Yes, the PR changes some user-facing errors. ### How was this patch tested? By running the affected test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" $ build/sbt "core/testOnly *SparkThrowableSuite" $ build/sbt "test:testOnly *StringExpressionsSuite" ``` Closes apache#38755 from MaxGekk/refactor-datatype-mismatch. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? In the PR, I propose to move out the error sub-classes related to number format issues from `DATATYPE_MISMATCH` to their own error class `INVALID_FORMAT`. Also, the PR deletes the error class `INVALID_LIKE_PATTERN`, and moves their sub-classes to `INVALID_FORMAT`. ### Why are the changes needed? To improve usability of Spark SQL and to don't confuse users by error class names related to values but to to its types. ### Does this PR introduce _any_ user-facing change? Yes, the PR changes some user-facing errors. ### How was this patch tested? By running the affected test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" $ build/sbt "core/testOnly *SparkThrowableSuite" $ build/sbt "test:testOnly *StringExpressionsSuite" ``` Closes apache#38755 from MaxGekk/refactor-datatype-mismatch. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to move out the error sub-classes related to number format issues from
DATATYPE_MISMATCHto their own error classINVALID_FORMAT. Also, the PR deletes the error classINVALID_LIKE_PATTERN, and moves their sub-classes toINVALID_FORMAT.Why are the changes needed?
To improve usability of Spark SQL and to don't confuse users by error class names related to values but to to its types.
Does this PR introduce any user-facing change?
Yes, the PR changes some user-facing errors.
How was this patch tested?
By running the affected test suites: