[SPARK-40834][SQL][FOLLOWUP] Take care of legacy query end events #38747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Nov 21, 2022
| var driverAccumUpdates = Seq[(Long, Long)]() | ||
|
|
||
| @volatile var metricsValues: Map[Long, String] = null | ||
| var errorMessage: Option[String] = None |
Contributor
Author
There was a problem hiding this comment.
nit: move errorMessage closer to completionTime, as they both indicate the end of the execution.
cloud-fan
commented
Nov 21, 2022
| val metrics: Seq[SQLPlanMetric], | ||
| val submissionTime: Long, | ||
| val completionTime: Option[Date], | ||
| val errorMessage: Option[String], |
ulysses-you
approved these changes
Nov 22, 2022
ulysses-you
reviewed
Nov 22, 2022
| System.currentTimeMillis(), | ||
| // Use empty string to indicate no error, as None may mean events generated by old | ||
| // versions of Spark. | ||
| errorMessage.orElse(Some(""))) |
Contributor
There was a problem hiding this comment.
Better to add docs at SparkListenerSQLExecutionEnd, Some("") is not an error. Otherwise developers may confuse.
Contributor
Author
|
thanks for review, merging to master! |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? This is a followup of apache#38302 . For events generated by old versions of Spark, which do not have the new `errorMessage` field, we should use the old way to detect query execution status (failed or not). This PR also adds a UI test for the expected behavior. ### Why are the changes needed? backward compatibility ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests Closes apache#38747 from cloud-fan/ui. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? This is a followup of apache#38302 . For events generated by old versions of Spark, which do not have the new `errorMessage` field, we should use the old way to detect query execution status (failed or not). This PR also adds a UI test for the expected behavior. ### Why are the changes needed? backward compatibility ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new tests Closes apache#38747 from cloud-fan/ui. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #38302 . For events generated by old versions of Spark, which do not have the new
errorMessagefield, we should use the old way to detect query execution status (failed or not).This PR also adds a UI test for the expected behavior.
Why are the changes needed?
backward compatibility
Does this PR introduce any user-facing change?
no
How was this patch tested?
new tests