[SPARK-41195][SQL] Support PIVOT/UNPIVOT with join children #38713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Nov 18, 2022
Contributor
Author
There was a problem hiding this comment.
I didn't add tests for pivot because:
- there is no pivot parser suite
- pivot/unpivot syntax is exactly the same regarding joins, no need to test both
Contributor
Author
srielau
reviewed
Nov 18, 2022
Contributor
There was a problem hiding this comment.
This doesn't look right.
As you say PIVOT and UNPIVOT are like JOINs, so why are do you have this strange ordered optional clauses instead of merging them in as if they were another type of join.
I can't put my finger on exactly how it breaks without running a bunch of tests.
For example I should be able to chain a string UNPIVOTs and PIVOTs in any order without the need for a JOIN (or a braces) in between. I don't see how that works here.
Comment on lines
704
to
705
Contributor
There was a problem hiding this comment.
Have you tried simply:
Suggested change
| : (joinType) JOIN LATERAL? right=relationPrimary joinCriteria? pivotClause? unpivotClause? | |
| | NATURAL joinType JOIN LATERAL? right=relationPrimary pivotClause? unpivotClause? | |
| : (joinType) JOIN LATERAL? right=relationPrimary joinCriteria? | |
| | NATURAL joinType JOIN LATERAL? right=relationPrimary | |
| | pivotClause | |
| | unpivotClause |
Also removing the relation entries above?
cloud-fan
commented
Nov 21, 2022
| * Join one more [[LogicalPlan]] to the current logical plan. | ||
| */ | ||
| private def withJoinRelations(base: LogicalPlan, ctx: RelationContext): LogicalPlan = { | ||
| ctx.joinRelation.asScala.foldLeft(base) { (left, join) => |
Contributor
Author
There was a problem hiding this comment.
The actual code change is very small, just remove this loop and rename a few variables.
Member
|
Thanks, merging to master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Today, our SQL parser only supports PIVOT/UNPIVOT at the end of the FROM clause. This is quite limited and it's better to allow PIVOT/UNPIVOT in the join children as well. As a reference, snowflake supports it: https://docs.snowflake.com/en/sql-reference/constructs/from.html This PR makes PIVOT/UNPIVOT the same level as JOIN. Wherever you can use JOIN to extend a relation, you can also use PIVOT/UNPIVOT. Many SQL syntaxes are supported after this PR ``` FROM t1 PIVOT/UNPIVOT ... JOIN t2 // pivot/unpivot the left table FROM t1 JOIN t2 PIVOT/UNPIVOT ... // pivot/unpivot the join result. This is the same before this PR FROM t1 JOIN (t2 PIVOT/UNPIVOT ...) // pivot/unpivot the right table FROM t1 PIVOT/UNPIVOT ... PIVOT/UNPIVOT // nested pivot/unpivot ``` ### Why are the changes needed? make PIVOT/UNPIVOT syntax more flexible ### Does this PR introduce _any_ user-facing change? Yes, new SQL syntax without any breaking change ### How was this patch tested? new parser tests Closes apache#38713 from cloud-fan/pivot. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? Today, our SQL parser only supports PIVOT/UNPIVOT at the end of the FROM clause. This is quite limited and it's better to allow PIVOT/UNPIVOT in the join children as well. As a reference, snowflake supports it: https://docs.snowflake.com/en/sql-reference/constructs/from.html This PR makes PIVOT/UNPIVOT the same level as JOIN. Wherever you can use JOIN to extend a relation, you can also use PIVOT/UNPIVOT. Many SQL syntaxes are supported after this PR ``` FROM t1 PIVOT/UNPIVOT ... JOIN t2 // pivot/unpivot the left table FROM t1 JOIN t2 PIVOT/UNPIVOT ... // pivot/unpivot the join result. This is the same before this PR FROM t1 JOIN (t2 PIVOT/UNPIVOT ...) // pivot/unpivot the right table FROM t1 PIVOT/UNPIVOT ... PIVOT/UNPIVOT // nested pivot/unpivot ``` ### Why are the changes needed? make PIVOT/UNPIVOT syntax more flexible ### Does this PR introduce _any_ user-facing change? Yes, new SQL syntax without any breaking change ### How was this patch tested? new parser tests Closes apache#38713 from cloud-fan/pivot. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? Today, our SQL parser only supports PIVOT/UNPIVOT at the end of the FROM clause. This is quite limited and it's better to allow PIVOT/UNPIVOT in the join children as well. As a reference, snowflake supports it: https://docs.snowflake.com/en/sql-reference/constructs/from.html This PR makes PIVOT/UNPIVOT the same level as JOIN. Wherever you can use JOIN to extend a relation, you can also use PIVOT/UNPIVOT. Many SQL syntaxes are supported after this PR ``` FROM t1 PIVOT/UNPIVOT ... JOIN t2 // pivot/unpivot the left table FROM t1 JOIN t2 PIVOT/UNPIVOT ... // pivot/unpivot the join result. This is the same before this PR FROM t1 JOIN (t2 PIVOT/UNPIVOT ...) // pivot/unpivot the right table FROM t1 PIVOT/UNPIVOT ... PIVOT/UNPIVOT // nested pivot/unpivot ``` ### Why are the changes needed? make PIVOT/UNPIVOT syntax more flexible ### Does this PR introduce _any_ user-facing change? Yes, new SQL syntax without any breaking change ### How was this patch tested? new parser tests Closes apache#38713 from cloud-fan/pivot. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Today, our SQL parser only supports PIVOT/UNPIVOT at the end of the FROM clause. This is quite limited and it's better to allow PIVOT/UNPIVOT in the join children as well. As a reference, snowflake supports it: https://docs.snowflake.com/en/sql-reference/constructs/from.html
This PR makes PIVOT/UNPIVOT the same level as JOIN. Wherever you can use JOIN to extend a relation, you can also use PIVOT/UNPIVOT. Many SQL syntaxes are supported after this PR
Why are the changes needed?
make PIVOT/UNPIVOT syntax more flexible
Does this PR introduce any user-facing change?
Yes, new SQL syntax without any breaking change
How was this patch tested?
new parser tests