[SPARK-41005][COLLECT][FOLLOWUP] Remove JSON code path and use RDD.collect in Arrow code path
#38706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Nov 18, 2022
HyukjinKwon
reviewed
Nov 18, 2022
Member
There was a problem hiding this comment.
let's also remove this and protobuf definition
zhengruifeng
changed the title
zhengruifeng
force-pushed
the
collect_disable_json
branch
from
4c79820 to
ed59e6c
Compare
zhengruifeng
changed the title
RDD.collect in Arrow code path
zhengruifeng
changed the title
RDD.collect in Arrow code pathRDD.collect in Arrow code path
cloud-fan
approved these changes
Nov 21, 2022
Member
|
Merged to master. |
Contributor
|
Sorry for late comment but just one question: does this implementation always send at least one partition to client even if there is empty result? |
Contributor
Author
will send at least one batch. |
Contributor
|
@zhengruifeng thanks for this work! LGTM |
Contributor
|
late LGTM |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ollect` in Arrow code path ### What changes were proposed in this pull request? 1, Remove JSON code path; 2, use RDD.collect in Arrow code path, since existing tests were already broken in Arrow code path; 3, reenable `test_fill_na` ### Why are the changes needed? existing Arrow code path is still problematic and it fails and fallback to JSON code path, which change the output datatypes of `test_fill_na` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? reenabled test and added UT Closes apache#38706 from zhengruifeng/collect_disable_json. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…ollect` in Arrow code path ### What changes were proposed in this pull request? 1, Remove JSON code path; 2, use RDD.collect in Arrow code path, since existing tests were already broken in Arrow code path; 3, reenable `test_fill_na` ### Why are the changes needed? existing Arrow code path is still problematic and it fails and fallback to JSON code path, which change the output datatypes of `test_fill_na` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? reenabled test and added UT Closes apache#38706 from zhengruifeng/collect_disable_json. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…ollect` in Arrow code path ### What changes were proposed in this pull request? 1, Remove JSON code path; 2, use RDD.collect in Arrow code path, since existing tests were already broken in Arrow code path; 3, reenable `test_fill_na` ### Why are the changes needed? existing Arrow code path is still problematic and it fails and fallback to JSON code path, which change the output datatypes of `test_fill_na` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? reenabled test and added UT Closes apache#38706 from zhengruifeng/collect_disable_json. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1, Remove JSON code path;
2, use RDD.collect in Arrow code path, since existing tests were already broken in Arrow code path;
3, reenable
test_fill_naWhy are the changes needed?
existing Arrow code path is still problematic and it fails and fallback to JSON code path, which change the output datatypes of
test_fill_naDoes this PR introduce any user-facing change?
No
How was this patch tested?
reenabled test and added UT