[SPARK-41193][SQL][TESTS] Ignore collect data with single partition larger than 2GB bytes array limit in DatasetLargeResultCollectingSuite
#38704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon |
mridulm
reviewed
Nov 18, 2022
| // default Java Options, if user need do local test, please make the following changes: | ||
| // - Maven test: change `-Xmx4g` of `scalatest-maven-plugin` in `sql/core/pom.xml` to `-Xmx10g` | ||
| // - SBT test: change `-Xmx4g` of `Test / javaOptions` in `SparkBuild.scala` to `-Xmx10g` | ||
| ignore("collect data with single partition larger than 2GB bytes array limit") { |
Contributor
There was a problem hiding this comment.
@liuzqt, I know this was iterated on multiple times to get it to work - instead of the shared local spark session, did it work locally when using a local spark cluster instead ?
Contributor
There was a problem hiding this comment.
Yes @LuciferYang is right, need to change -Xmx4g to -Xmx10g to make it work (it works for both shared local session and local cluster, but without the change neither work).
Thanks for the fix! Previously I only tested this using IDE and I guess it increased the mem under the hood......Sorry for the inconvenience.
Contributor
Author
There was a problem hiding this comment.
So how do we move forward? This is a blocking for developers
Contributor
There was a problem hiding this comment.
I think we can leave it as ignore for now with the comments about using larger mem to make it work. I'm not sure if we're able to configure the build args for a specific test suite.
Contributor
Author
|
friendly ping @HyukjinKwon |
Member
|
Merged to master. |
Contributor
Author
|
Thanks @HyukjinKwon @mridulm @liuzqt |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…larger than 2GB bytes array limit` in `DatasetLargeResultCollectingSuite` ### What changes were proposed in this pull request? This pr ignore `collect data with single partition larger than 2GB bytes array limit` in `DatasetLargeResultCollectingSuite` as default due it cannot run successfully with Spark default Java Options. ### Why are the changes needed? Avoid local test failure. ### Does this PR introduce _any_ user-facing change? No, just for test ### How was this patch tested? - Pass GA - Manual test: in my test environment, change `-Xmx4g` to `-Xmx10g`, maven and sbt can test successfully in my Closes apache#38704 from LuciferYang/SPARK-41193. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
…larger than 2GB bytes array limit` in `DatasetLargeResultCollectingSuite` ### What changes were proposed in this pull request? This pr ignore `collect data with single partition larger than 2GB bytes array limit` in `DatasetLargeResultCollectingSuite` as default due it cannot run successfully with Spark default Java Options. ### Why are the changes needed? Avoid local test failure. ### Does this PR introduce _any_ user-facing change? No, just for test ### How was this patch tested? - Pass GA - Manual test: in my test environment, change `-Xmx4g` to `-Xmx10g`, maven and sbt can test successfully in my Closes apache#38704 from LuciferYang/SPARK-41193. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
…larger than 2GB bytes array limit` in `DatasetLargeResultCollectingSuite` ### What changes were proposed in this pull request? This pr ignore `collect data with single partition larger than 2GB bytes array limit` in `DatasetLargeResultCollectingSuite` as default due it cannot run successfully with Spark default Java Options. ### Why are the changes needed? Avoid local test failure. ### Does this PR introduce _any_ user-facing change? No, just for test ### How was this patch tested? - Pass GA - Manual test: in my test environment, change `-Xmx4g` to `-Xmx10g`, maven and sbt can test successfully in my Closes apache#38704 from LuciferYang/SPARK-41193. Authored-by: yangjie01 <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr ignore
collect data with single partition larger than 2GB bytes array limitinDatasetLargeResultCollectingSuiteas default due it cannot run successfully with Spark default Java Options.Why are the changes needed?
Avoid local test failure.
Does this PR introduce any user-facing change?
No, just for test
How was this patch tested?
-Xmx4gto-Xmx10g, maven and sbt can test successfully in my