Skip to content

[SPARK-41005][CONNECT][FOLLOWUP] Collect should use submitJob instead of runJob #38614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 1 commit into from
Closed

[SPARK-41005][CONNECT][FOLLOWUP] Collect should use submitJob instead of runJob #38614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...nnect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,17 +160,24 @@ class SparkConnectStreamHandler(responseObserver: StreamObserver[Response]) exte
()
}

spark.sparkContext.runJob(batches, processPartition, resultHandler)
spark.sparkContext.submitJob(
rdd = batches,
processPartition = processPartition,
partitions = Seq.range(0, numPartitions),
resultHandler = resultHandler,
resultFunc = () => ())

// The man thread will wait until 0-th partition is available,
// then send it to client and wait for next partition.
// then send it to client and wait for the next partition.
var currentPartitionId = 0
while (currentPartitionId < numPartitions) {
val partition = signal.synchronized {
while (!partitions.contains(currentPartitionId)) {
var result = partitions.remove(currentPartitionId)
while (result.isEmpty) {
signal.wait()
result = partitions.remove(currentPartitionId)
}
partitions.remove(currentPartitionId).get
result.get
}

partition.foreach { case (bytes, count) =>
Expand Down