-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40948][SQL][FOLLOWUP] Restore PATH_NOT_FOUND #38575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
Outdated
Show resolved
Hide resolved
|
Is the sparkr UTs failure is related to this one? https://github.com/itholic/spark/actions/runs/3425639144/jobs/5708796073 |
|
Looks like we need to refactor this case spark/R/pkg/tests/fulltests/test_sparkSQL.R Lines 3986 to 3998 in c5d2760
|
| expect_error(read.text("arbitrary_path"), "Error in text : analysis error - Path does not exist") | ||
| expect_error(read.orc("arbitrary_path"), "Error in orc : analysis error - Path does not exist") | ||
| expect_error(read.df("arbitrary_path"), | ||
| "Error in load : analysis error - \\[PATH_NOT_FOUND\\].*") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon @srielau @cloud-fan Are you ok with such changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: the arbitrary_path here is different per test environments, so I use regexp for the path string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks man
|
+1, LGTM. Merging to master. |
### What changes were proposed in this pull request? The original PR to introduce the error class `PATH_NOT_FOUND` was reverted since it breaks the tests in different test env. This PR proposes to restore it back. ### Why are the changes needed? Restoring the reverted changes with proper fix. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The existing CI should pass. Closes apache#38575 from itholic/SPARK-40948-followup. Authored-by: itholic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
### What changes were proposed in this pull request? The original PR to introduce the error class `PATH_NOT_FOUND` was reverted since it breaks the tests in different test env. This PR proposes to restore it back. ### Why are the changes needed? Restoring the reverted changes with proper fix. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The existing CI should pass. Closes apache#38575 from itholic/SPARK-40948-followup. Authored-by: itholic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
What changes were proposed in this pull request?
The original PR to introduce the error class
PATH_NOT_FOUNDwas reverted since it breaks the tests in different test env.This PR proposes to restore it back.
Why are the changes needed?
Restoring the reverted changes with proper fix.
Does this PR introduce any user-facing change?
No
How was this patch tested?
The existing CI should pass.