[SPARK-41010][CONNECT][PYTHON] Complete Support for Except and Intersect in Python client #38506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect in Python client.
Contributor
Author
|
R: @HyukjinKwon |
Contributor
Author
|
actually I will follow https://spark.apache.org/contributing.html. to add a short description for test cases in this PR/ |
Contributor
Author
|
Ok added short description for the new test cases. |
|
Can one of the admins verify this patch? |
zhengruifeng
reviewed
Nov 9, 2022
Co-authored-by: Ruifeng Zheng <[email protected]>
zhengruifeng
approved these changes
Nov 10, 2022
Contributor
|
merged into master |
HyukjinKwon
reviewed
Nov 10, 2022
| <ul> | ||
| <li> | ||
| <b>Union</b><br /> | ||
| <b>SetOperation</b><br /> |
Member
There was a problem hiding this comment.
qq: why don't we have Except, Union, etc separately?
Contributor
Author
There was a problem hiding this comment.
@HyukjinKwon I hope this discussion can answer your question #38166 (comment)....
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ect in Python client ### What changes were proposed in this pull request? 1. Add support for intersect and except. 2. Unify union, intersect and except into `SetOperation`. ### Why are the changes needed? Improve API coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38506 from amaliujia/except_python. Authored-by: Rui Wang <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SetOperation.Why are the changes needed?
Improve API coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT