[MINOR][DOC] updated some grammar and a missed period in the tuning doc #38499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k completes, as it sounds strange
…roadcasting large variables)
…points of data locality didnt have commas or periods but periods were being used for multiple sentences in a bullet points. I opted for periods but could be commas with last one using and then period
Contributor
Author
|
Do I need to report test results for a doc change? Also, I am not sure I understand how to do that. Thanks for any feedback. |
|
Can one of the admins verify this patch? |
itholic
approved these changes
Nov 4, 2022
Contributor
Author
I can add it. I was reading over this doc which is why I noticed them. Just a render markdown screenshot or the text file? Or side by side? @itholic |
srowen
approved these changes
Nov 5, 2022
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
This is fine, but fairly trivial - let's do one big PR with many docs if going to do this
Member
|
Merged to master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? I changed some grammatical issues in the documentation. One potential change could be debatable though so please take a look. https://spark.apache.org/docs/latest/tuning.html ### Why are the changes needed? Some grammatical mistakes in the documentation. ### Does this PR introduce _any_ user-facing change? Yes, this corrects some issues in documentation related to Tuning Spark. The following changes were made Check if there are too many garbage collections by collecting GC stats. If a full GC is invoked multiple times ~~for~~ before a task completes, it means that there isn't enough memory available for executing tasks. with `-XX:G1HeapRegionSize`. (added missing period). we can estimate the size of Eden to be `4*3*128MiB`. (added the to estimate the size--this one I guess debatable) ### How was this patch tested? No tests added as this was markdown documentation for the user facing page. Closes apache#38499 from dwsmith1983/master. Lead-authored-by: Dustin William Smith <[email protected]> Co-authored-by: dustin <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I changed some grammatical issues in the documentation. One potential change could be debatable though so please take a look.
https://spark.apache.org/docs/latest/tuning.html
Why are the changes needed?
Some grammatical mistakes in the documentation.
Does this PR introduce any user-facing change?
Yes, this corrects some issues in documentation related to Tuning Spark. The following changes were made
Check if there are too many garbage collections by collecting GC stats. If a full GC is invoked multiple times
forbefore a task completes, it means that there isn't enough memory available for executing tasks.
with
-XX:G1HeapRegionSize. (added missing period).we can estimate the size of Eden to be
4*3*128MiB. (added the to estimate the size--this one I guess debatable)How was this patch tested?
No tests added as this was markdown documentation for the user facing page.