-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-35531][SQL] Update hive table stats without unnecessary convert #38495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e763d0a
[SPARK-35531][SQL] Update hive table stats without unecessary convert
wankunde 12e1642
Bug fix
wankunde 41890de
Fix UT
wankunde 395b571
Update code
wankunde 8760da9
Update code
wankunde be0c869
Update code
wankunde 3115a62
Bug fix
wankunde ee08735
Add hiveTableProps method in hiveTableProps
wankunde 6ebaa06
Use filterNot method instead of filterKeys method
wankunde bad2444
Remove containsStats parameter in hiveTableProps method
wankunde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,6 +113,9 @@ private[hive] trait HiveClient { | |
| /** Creates a table with the given metadata. */ | ||
| def createTable(table: CatalogTable, ignoreIfExists: Boolean): Unit | ||
|
|
||
| /** Get hive table properties. */ | ||
| def hiveTableProps(rawHiveTable: RawHiveTable, containsStats: Boolean): Map[String, String] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall we add a method in |
||
|
|
||
| /** Drop the specified table. */ | ||
| def dropTable(dbName: String, tableName: String, ignoreIfNotExists: Boolean, purge: Boolean): Unit | ||
|
|
||
|
|
@@ -127,6 +130,9 @@ private[hive] trait HiveClient { | |
| */ | ||
| def alterTable(dbName: String, tableName: String, table: CatalogTable): Unit | ||
|
|
||
| /** Alter a table properties */ | ||
| def alterTableProps(rawHiveTable: RawHiveTable, newProps: Map[String, String]): Unit | ||
|
|
||
| /** | ||
| * Updates the given table with a new data schema and table properties, and keep everything else | ||
| * unchanged. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cloud-fan