[SPARK-40985][BUILD] Upgrade RoaringBitmap to 0.9.35 #38465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
reviewed
Nov 2, 2022
| Num Maps: 50000 Fetch partitions:500 1269 1276 8 0.0 1268666001.0 1.0X | ||
| Num Maps: 50000 Fetch partitions:1000 2672 2695 39 0.0 2671542753.0 0.5X | ||
| Num Maps: 50000 Fetch partitions:1500 4034 4069 50 0.0 4033696987.0 0.3X | ||
| Num Maps: 50000 Fetch partitions:500 1227 1262 47 0.0 1226744907.0 1.0X |
Contributor
There was a problem hiding this comment.
Just out of curiosity, seems like the Stdev slow-dowm almost 6x, it is acceptable performance degradation?
Contributor
Author
There was a problem hiding this comment.
Stdev refers to the standard deviation estimated based on the sample. The standard deviation reflects the dispersion of the value relative to the mean.
From Per Row(ns), although the cpu frequency of the tester is slower than the base, the performance has not changed significantly
HyukjinKwon
approved these changes
Nov 2, 2022
srowen
approved these changes
Nov 2, 2022
Member
|
Merged to master |
Contributor
Author
|
Thanks @srowen @HyukjinKwon @itholic |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This pr aims upgrade RoaringBitmap 0.9.35 ### Why are the changes needed? This version bring some bug fix: - RoaringBitmap/RoaringBitmap#587 - RoaringBitmap/RoaringBitmap#588 other changes as follows: RoaringBitmap/RoaringBitmap@0.9.32...0.9.35 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#38465 from LuciferYang/rbitmap-0935. Authored-by: yangjie01 <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims upgrade RoaringBitmap 0.9.35
Why are the changes needed?
This version bring some bug fix:
other changes as follows:
RoaringBitmap/RoaringBitmap@0.9.32...0.9.35
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions