[SPARK-40533] [CONNECT] [PYTHON] Support most built-in literal types for Python in Spark Connect #38462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
Nov 3, 2022
HyukjinKwon
reviewed
Nov 3, 2022
Contributor
Author
|
@HyukjinKwon removed the UUID support, please have another look. |
HyukjinKwon
reviewed
Nov 4, 2022
| exp.literal.decimal.scale = abs(v_tuple.exponent) | ||
| exp.literal.decimal.precision = len(v_tuple.digits) - abs(v_tuple.exponent) | ||
| # Two complement yeah... | ||
| raise ValueError("Python Decimal not supported.") |
Member
There was a problem hiding this comment.
Can we remove if this is not implemented yet?
HyukjinKwon
reviewed
Nov 4, 2022
| # Days since epoch. | ||
| days_since_epoch = (cast(datetime.date, self._value) - datetime.date(1970, 1, 1)).days | ||
| exp.literal.date = days_since_epoch | ||
| elif value_type is uuid.UUID: |
Member
There was a problem hiding this comment.
Maybe we could remove elif so else branch throw the exception?
HyukjinKwon
reviewed
Nov 4, 2022
| # Microseconds since epoch. | ||
| dt = cast(datetime.datetime, self._value) | ||
| v = dt - datetime.datetime(1970, 1, 1, 0, 0, 0, 0) | ||
| exp.literal.timestamp = int(v / datetime.timedelta(microseconds=1)) |
Member
There was a problem hiding this comment.
Can we maybe match the implementation in PySpark's: https://github.com/apache/spark/blob/master/python/pyspark/sql/types.py#L254-L260 ?
HyukjinKwon
approved these changes
Nov 4, 2022
Member
|
Merged to master. Let's address complete types in a followup. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…r Python in Spark Connect ### What changes were proposed in this pull request? This PR implements the client-side serialization of most Python literals into Spark Connect literals. ### Why are the changes needed? Expanding the Python client support. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38462 from grundprinzip/SPARK-40533. Lead-authored-by: Martin Grund <[email protected]> Co-authored-by: Martin Grund <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR implements the client-side serialization of most Python literals into Spark Connect literals.
Why are the changes needed?
Expanding the Python client support.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT