[SPARK-40977][CONNECT][PYTHON] Complete Support for Union in Python client#38453
Closed
amaliujia wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-40977][CONNECT][PYTHON] Complete Support for Union in Python client#38453amaliujia wants to merge 1 commit intoapache:masterfrom
amaliujia wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Can one of the admins verify this patch? |
zhengruifeng
approved these changes
Nov 2, 2022
HyukjinKwon
approved these changes
Nov 3, 2022
Member
|
Merged to master. |
HyukjinKwon
reviewed
Nov 3, 2022
| self.assertIsNotNone(plan.root, "Root relation must be set") | ||
| self.assertIsNotNone(plan.root.read) | ||
|
|
||
| def test_union(self): |
Member
There was a problem hiding this comment.
Actually we should add a comment like:
def test_union(self):
# SPARK-12345: a short description of the test
...per https://spark.apache.org/contributing.html. Let's don't forget this next time :-).
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…lient ### What changes were proposed in this pull request? 1. Improve testing coverage for `Union` and `UnionAll` (they are actually both `UnionAll`) 2. Add the API which does `UnionByName`. ### Why are the changes needed? Improve API Coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38453 from amaliujia/python_union. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
UnionandUnionAll(they are actually bothUnionAll)UnionByName.Why are the changes needed?
Improve API Coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT