[SPARK-40798][SQL][FOLLOW-UP] Fix ansi mode in v2 ALTER TABLE PARTITION #38449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
HyukjinKwon
reviewed
Nov 1, 2022
|
|
||
| withSQLConf( | ||
| SQLConf.SKIP_TYPE_VALIDATION_ON_ALTER_PARTITION.key -> "true", | ||
| SQLConf.ANSI_ENABLED.key -> "false") { |
Member
There was a problem hiding this comment.
Shouldn't we maybe keep the test after removing SQLConf.ANSI_ENABLED.key -> "false"?
Contributor
Author
There was a problem hiding this comment.
Before I thought the storeAssignmentPolicy is enough so this test is corvered by AlterTableAddPartitionSuiteBase. Just change to legacy to restroe previous behavior.
Now I add one more SKIP_TYPE_VALIDATION_ON_ALTER_PARTITION check and keep this test.
cloud-fan
approved these changes
Nov 1, 2022
HyukjinKwon
approved these changes
Nov 1, 2022
Contributor
Author
|
@HyukjinKwon @cloud-fan hope we can get this in if you find some time, thank you |
Member
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Change to plain cast to `PartitioningUtils.castPartitionSpec` in convertToPartIdent. So the behavior can follow the `STORE_ASSIGNMENT_POLICY`. ### Why are the changes needed? Make v2 code path ALTER PARTITION follows `STORE_ASSIGNMENT_POLICY` in ansi mode. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? remove the test `SPARK-40798: Alter partition should verify partition value - legacy`. This change has been convered at : `SPARK-40798: Alter partition should verify partition value` Closes apache#38449 from ulysses-you/SPARK-40798-follow. Authored-by: ulysses-you <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change to plain cast to
PartitioningUtils.castPartitionSpecin convertToPartIdent. So the behavior can follow theSTORE_ASSIGNMENT_POLICY.Why are the changes needed?
Make v2 code path ALTER PARTITION follows
STORE_ASSIGNMENT_POLICYin ansi mode.Does this PR introduce any user-facing change?
no
How was this patch tested?
remove the test
SPARK-40798: Alter partition should verify partition value - legacy.This change has been convered at :
SPARK-40798: Alter partition should verify partition value