Skip to content

Conversation

@panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to replace 'intercept' with 'Check error classes' in PlanResolutionSuite.

Why are the changes needed?

The changes improve the error framework.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the modified test suite:

$ build/sbt "test:testOnly *PlanResolutionSuite"

@github-actions github-actions bot added the SQL label Oct 28, 2022
Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Ci.

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxGekk
Copy link
Member

MaxGekk commented Oct 28, 2022

+1, LGTM. Merging to master.
Thank you, @panbingkun and @itholic for review.

@MaxGekk MaxGekk closed this in 7b4dfa3 Oct 28, 2022
@panbingkun panbingkun deleted the SPARK-40889 branch November 7, 2022 01:58
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?
This PR aims to replace 'intercept' with 'Check error classes' in PlanResolutionSuite.

### Why are the changes needed?
The changes improve the error framework.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "test:testOnly *PlanResolutionSuite"
```

Closes apache#38421 from panbingkun/SPARK-40889.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants