[SPARK-40936][SQL][TESTS] Refactor AnalysisTest#assertAnalysisErrorClass by reusing the SparkFunSuite#checkError

[LuciferYang]

What changes were proposed in this pull request?

This pr aims to refactor AnalysisTest#assertAnalysisErrorClass method by reusing the checkError method in SparkFunSuite.

On the other hand, the signature of AnalysisTest#assertAnalysisErrorClass method is changed from

protected def assertAnalysisErrorClass(
      inputPlan: LogicalPlan,
      expectedErrorClass: String,
      expectedMessageParameters: Map[String, String],
      caseSensitive: Boolean = true,
      line: Int = -1,
      pos: Int = -1): Unit

to

protected def assertAnalysisErrorClass(
      inputPlan: LogicalPlan,
      expectedErrorClass: String,
      expectedMessageParameters: Map[String, String],
      queryContext: Array[QueryContext] = Array.empty,
      caseSensitive: Boolean = true): Unit

Then when we need to use queryContext instead of line + pos for assertion

Why are the changes needed?

assertAnalysisErrorClass and checkError does the same work.

Does this PR introduce any user-facing change?

No, just for test

How was this patch tested?

• Pass GitHub Actions

[LuciferYang]

cc @MaxGekk @HyukjinKwon @dongjoon-hyun Think again, does this refactor look more simple?

[MaxGekk]

I wonder why do we need assertAnalysisErrorClass() at all. checkError does the same job. Seems like assertAnalysisErrorClass() checks additionally case sensitivity (can be done in test explicitly if it is really needed) + checking line + pos (we should check query context instead of that, I guess).

Let's consider to invoke checkError in assertAnalysisErrorClass() or remove it completely (invoke checkError() directly in tests as we do in other places).

[LuciferYang]

assertAnalysisErrorClass

Sounds good, let me try. Set this to draft first and will ping you when it can be reviewed @MaxGekk

[LuciferYang]

spark/core/src/test/scala/org/apache/spark/SparkFunSuite.scala

Lines 319 to 332 in cf086b1

	val actualQueryContext = exception.getQueryContext()
	assert(actualQueryContext.length === queryContext.length, "Invalid length of the query context")
	actualQueryContext.zip(queryContext).foreach { case (actual, expected) =>
	assert(actual.objectType() === expected.objectType(),
	"Invalid objectType of a query context Actual:" + actual.toString)
	assert(actual.objectName() === expected.objectName(),
	"Invalid objectName of a query context. Actual:" + actual.toString)
	assert(actual.startIndex() === expected.startIndex(),
	"Invalid startIndex of a query context. Actual:" + actual.toString)
	assert(actual.stopIndex() === expected.stopIndex(),
	"Invalid stopIndex of a query context. Actual:" + actual.toString)
	assert(actual.fragment() === expected.fragment(),
	"Invalid fragment of a query context. Actual:" + actual.toString)
	}

This change is due to the checkError method will perform a forced check when actualQueryContext is not empty. If we can to relax some check conditions, can add a precondition queryContext.nonEmpty for the queryContext check.

[LuciferYang]

@MaxGekk

Refactor assertAnalysisErrorClass method:

• Reuse checkError in assertAnalysisErrorClass
• Use queryContext instead of line + pos in assertAnalysisErrorClass method signature
• Fixed related tests

Please review this if you have time, thanks ~

[MaxGekk]

Waiting for Ci.

[LuciferYang]

GA passed

[MaxGekk]

+1, LGTM. Merging to master.
Thank you, @LuciferYang.