[SPARK-40933][SQL] Reimplement df.stat.{cov, corr} with built-in sql functions #38411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Oct 27, 2022
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM but to confirm, are they exactly same? or are there corcer case behaciour differences? If there are, we should note it in the migration guide.
Contributor
Author
|
seems different null handling, let me update this PR |
Contributor
Author
|
@HyukjinKwon as far as I know, they are the same now. the original tests didn't cover null handling and empty dataset, I add a new UT to make sure no behavior change. |
itholic
approved these changes
Oct 28, 2022
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
force-pushed
the
sql_stat_corr_cov
branch
from
cf5898d to
bf98997
Compare
Member
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…functions
### What changes were proposed in this pull request?
Make df.stat.{cov, corr} consistent with sql functions
### Why are the changes needed?
it is weird to have two implemetations in SQL
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
existing UTs
Closes apache#38411 from zhengruifeng/sql_stat_corr_cov.
Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make df.stat.{cov, corr} consistent with sql functions
Why are the changes needed?
it is weird to have two implemetations in SQL
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing UTs