Skip to content

[SPARK-40919][SQL][TESTS] Fix AnalysisTest#assertAnalysisErrorClass to avoid wrong check result when expectedMessageParameters.size <= 4 #38396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 4 commits into from
Closed

[SPARK-40919][SQL][TESTS] Fix AnalysisTest#assertAnalysisErrorClass to avoid wrong check result when expectedMessageParameters.size <= 4 #38396

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
733375a
fix
LuciferYang Oct 26, 2022
70eb638
change to use ==
LuciferYang Oct 26, 2022
3d04675
change to use !=
LuciferYang Oct 26, 2022
22b76c1
fix indentation
LuciferYang Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ trait AnalysisTest extends PlanTest {
}

if (e.getErrorClass != expectedErrorClass ||
!e.messageParameters.sameElements(expectedMessageParameters) ||
!(e.messageParameters == expectedMessageParameters) ||
Copy link
Member

@MaxGekk MaxGekk Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify this and use != instead of combination of ! and ==.

Copy link
Contributor Author

@LuciferYang LuciferYang Oct 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

(line >= 0 && e.line.getOrElse(-1) != line) ||
(pos >= 0) && e.startPosition.getOrElse(-1) != pos) {
var failMsg = ""
Expand All @@ -194,7 +194,7 @@ trait AnalysisTest extends PlanTest {
|Actual error class: ${e.getErrorClass}
""".stripMargin
}
if (!e.messageParameters.sameElements(expectedMessageParameters)) {
if (!(e.messageParameters == expectedMessageParameters)) {
failMsg +=
s"""Message parameters should be: ${expectedMessageParameters.mkString("\n ")}
|Actual message parameters: ${e.messageParameters.mkString("\n ")}
Expand Down