[SPARK-40913][INFRA] Pin pytest==7.1.3
#38390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I compare the failed CI with a green one: the major difference is the version of pytest, but I can not reproduce the failure locally with pytest=7.2.0, not sure whether it can fix the master |
zhengruifeng
changed the title
pytest==7.1.3pytest==7.1.3
Contributor
Author
|
the python linter passed |
HyukjinKwon
approved these changes
Oct 25, 2022
Member
|
Merged to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 25, 2022
Pin pytest==7.1.3 `pytest-mypy-plugins==1.9.3` depends on `pytest [required: >=6.0.0]`, [pytest 7.2.0](https://pypi.org/project/pytest/) is released just now I guess it breaks the python linter ``` Traceback (most recent call last): File "/usr/local/bin/pytest", line 8, in <module> sys.exit(console_main()) File "/usr/local/lib/python3.9/dist-packages/_pytest/config/__init__.py", line 190, in console_main code = main() File "/usr/local/lib/python3.9/dist-packages/_pytest/config/__init__.py", line 148, in main config = _prepareconfig(args, plugins) ``` No CI, but can not reproduce locally Closes #38390 from zhengruifeng/infra_pin_pytest. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 25a9dfc) Signed-off-by: Hyukjin Kwon <[email protected]>
Member
|
Merged to branch-3.3 too. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Pin pytest==7.1.3 ### Why are the changes needed? `pytest-mypy-plugins==1.9.3` depends on `pytest [required: >=6.0.0]`, [pytest 7.2.0](https://pypi.org/project/pytest/) is released just now I guess it breaks the python linter ``` Traceback (most recent call last): File "/usr/local/bin/pytest", line 8, in <module> sys.exit(console_main()) File "/usr/local/lib/python3.9/dist-packages/_pytest/config/__init__.py", line 190, in console_main code = main() File "/usr/local/lib/python3.9/dist-packages/_pytest/config/__init__.py", line 148, in main config = _prepareconfig(args, plugins) ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI, but can not reproduce locally Closes apache#38390 from zhengruifeng/infra_pin_pytest. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pin pytest==7.1.3
Why are the changes needed?
pytest-mypy-plugins==1.9.3depends onpytest [required: >=6.0.0], pytest 7.2.0 is released just nowI guess it breaks the python linter
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI, but can not reproduce locally