[SPARK-40904][K8S] Support zsh in K8s entrypoint.sh
#38380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
zsh in K8s entrypoint.sh
Member
Author
|
All tests passed. Could you review this, please, @viirya ? |
viirya
approved these changes
Oct 25, 2022
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Looks good. How about just leave one line (non-readarray case)?
Member
Author
|
Thank you, @viirya . The |
Member
Author
|
Merged to master for Apache Spark 3.4.0. |
Member
Author
|
Thank you, @HyukjinKwon ! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request?
This PR aims to support `zsh` in K8s `entrypoint.sh`.
### Why are the changes needed?
`zsh` doesn't support `readarray`.
```
% readarray
zsh: command not found: readarray
```
Instead, `zsh` supports the following way.
```
% SPARK_EXECUTOR_JAVA_OPTS=("${(f)$(< /tmp/java_opts.txt)}")
% echo $SPARK_EXECUTOR_JAVA_OPTS[]
-Djava.net.preferIPv6Addresses=false -XX:+IgnoreUnrecognizedVMOptions --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.lang.reflect=ALL-UNNAMED --add-opens=java.base/java.io=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED --add-opens=java.base/sun.nio.cs=ALL-UNNAMED --add-opens=java.base/sun.security.action=ALL-UNNAMED --add-opens=java.base/sun.util.calendar=ALL-UNNAMED --add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED -Dspark.driver.blockManager.port=7079 -Dspark.driver.port=7078
```
### Does this PR introduce _any_ user-facing change?
No. This PR only introduces additional behavior when there is no `readarray` command.
### How was this patch tested?
Pass the K8s CIs.
Closes apache#38380 from dongjoon-hyun/SPARK-40904.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
zshin K8sentrypoint.sh.Why are the changes needed?
zshdoesn't supportreadarray.Instead,
zshsupports the following way.Does this PR introduce any user-facing change?
No. This PR only introduces additional behavior when there is no
readarraycommand.How was this patch tested?
Pass the K8s CIs.