[SPARK-40391][SQL][TESTS][FOLLOWUP] Change to use mockito-inline instead of manually write MockMaker
#38372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
mockito-inline instead of manually added MockMakermockito-inline instead of manually added MockMaker
Contributor
Author
|
|
LuciferYang
changed the title
mockito-inline instead of manually added MockMakermockito-inline instead of manually write MockMaker
panbingkun
approved these changes
Oct 24, 2022
Contributor
Author
Contributor
Author
|
@panbingkun as discuss offline, I run |
HyukjinKwon
approved these changes
Oct 24, 2022
Contributor
Author
|
All passed |
Member
|
Merged to master |
Contributor
Author
|
Thanks @srowen @HyukjinKwon @MaxGekk @panbingkun |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…stead of manually write MockMaker ### What changes were proposed in this pull request? This pr aims use `mockito-inline` instead of manually write `MockMaker` ### Why are the changes needed? `mockito-inline` is a more recommended [way](https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html#39) to use mockito to mocking final types, enums and final methods and `mllib` and `mllib-local` module is already using `mockito-inline`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions - Manual test:run `build/sbt clean "sql/testOnly *QueryExecutionErrorsSuite"` with Java 8u352, 11.0.17 and 17.0.5, all 3 Java versions passed Closes apache#38372 from LuciferYang/SPARK-40391. Authored-by: yangjie01 <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims use
mockito-inlineinstead of manually writeMockMakerWhy are the changes needed?
mockito-inlineis a more recommended way to use mockito to mocking final types, enums and final methodsand
mllibandmllib-localmodule is already usingmockito-inline.Does this PR introduce any user-facing change?
No
How was this patch tested?
build/sbt clean "sql/testOnly *QueryExecutionErrorsSuite"with Java 8u352, 11.0.17 and 17.0.5, all 3 Java versions passed