[SPARK-40898][SQL] Quote function names in datatype mismatch errors #38370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
Member
Author
|
@LuciferYang @panbingkun Could you review this PR, please. |
Contributor
|
The code change is fine to me, but it seems that some related tests need to be fixed |
cloud-fan
approved these changes
Oct 24, 2022
cloud-fan
reviewed
Oct 24, 2022
| "messageParameters" : { | ||
| "dataType" : "(\"INTERVAL MONTH\" or \"INTERVAL DAY\")", | ||
| "functionName" : "function array", | ||
| "functionName" : "`function array`", |
Contributor
There was a problem hiding this comment.
Should it be "function array"?
Member
Author
|
Merging to master. Thank you, @cloud-fan and @LuciferYang for review. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? In the PR, I propose to quote function names by `toSQLId()` that are passed to DataTypeMismatch as message parameters. ### Why are the changes needed? To be consistent w/ other error messages. ### Does this PR introduce _any_ user-facing change? Yes, it changes user-facing error message. ### How was this patch tested? By running the modified test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38370 from MaxGekk/quote-ids-datatype-mismatch. Authored-by: Max Gekk <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to quote function names by
toSQLId()that are passed to DataTypeMismatch as message parameters.Why are the changes needed?
To be consistent w/ other error messages.
Does this PR introduce any user-facing change?
Yes, it changes user-facing error message.
How was this patch tested?
By running the modified test suites: