-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-40777][SQL][PROTOBUF] Protobuf import support and move error-classes. #38344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
SandishKumarHN
wants to merge
25
commits into
apache:master
from
SandishKumarHN:SPARK-40777-ProtoErrorCls
Closed
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c6177a3
review changes nit
SandishKumarHN 8fad018
adding spark-protobuf error class into spark error-class framework
SandishKumarHN dac2fa8
adding spark-protobuf error class into spark error-class framework
SandishKumarHN d1c9b1e
adding spark-protobuf error class into spark error-class framework, i…
SandishKumarHN 03b918f
Merge remote-tracking branch 'remote-spark/master' into SPARK-40777
SandishKumarHN 60c2122
adding spark-protobuf error class into spark error-class framework, i…
SandishKumarHN 7c866de
Merge branch 'SPARK-40777' into SPARK-40777-ProtoErrorCls
SandishKumarHN e6f3cab
spark-protobuf error clss frameworks, import support, timestamp and d…
SandishKumarHN 70a5983
fixing typos
SandishKumarHN 26e471b
review changes, name protobuf error class and comment in pom.xml
SandishKumarHN 68f87c1
review chages rm includeMavenTypes and import own protos
SandishKumarHN 9cdf4d5
review changes: nested import support, nit, build fix
SandishKumarHN 4e1080e
review changes style changes, nit
SandishKumarHN dbaf24d
Merge remote-tracking branch 'remote-spark/master' into SPARK-40777-P…
SandishKumarHN 6045ffe
review changes: search messages on all imports
SandishKumarHN 3fc59b5
review changes: use prettyName
SandishKumarHN e5482a5
Merge remote-tracking branch 'remote-spark/master' into SPARK-40777-P…
SandishKumarHN dd63be8
review changes: nit, option, runtime error
SandishKumarHN e5140b0
error class name changes, more details to error message
SandishKumarHN 3037415
Merge remote-tracking branch 'remote-spark/master' into SPARK-40777-P…
SandishKumarHN be02c9e
NO_UDF_INTERFACE_ERROR to NO_UDF_INTERFACE
SandishKumarHN d8cce82
review changes scala style, find, parseFileDescriptorSet
SandishKumarHN ad1f7e1
Merge remote-tracking branch 'remote-spark/master' into SPARK-40777-P…
SandishKumarHN 48bcb5c
review changes buildDescriptor suggested changes
SandishKumarHN 87918a1
review changes, error classes
SandishKumarHN File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't quote it twice if you do that inside of
cannotConvertCatalystTypeToProtobufTypeError()bytoSQLIdThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, will call toSQLType inside the error class, avoid using toFieldStr for sqlType