Skip to content

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented Oct 20, 2022

What changes were proposed in this pull request?

Change set-output to GITHUB_OUTPUT.

Why are the changes needed?

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Does this PR introduce any user-facing change?

No, dev only

How was this patch tested?

@github-actions github-actions bot added the INFRA label Oct 20, 2022
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks OK if it passes

@Yikun Yikun marked this pull request as ready for review October 21, 2022 03:04
@Yikun
Copy link
Member Author

Yikun commented Oct 21, 2022

https://github.com/Yikun/spark/actions/runs/3294384181/jobs/5431945626
image

image

CI passed and benchmark job split works well in my local repo.

@Yikun Yikun closed this in 40086cb Oct 21, 2022
@Yikun
Copy link
Member Author

Yikun commented Oct 21, 2022

@srowen @HyukjinKwon Thanks, merge to master (3.4.0).

SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?
Change `set-output` to `GITHUB_OUTPUT`.

### Why are the changes needed?
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

### Does this PR introduce _any_ user-facing change?
No, dev only

### How was this patch tested?
- CI passed
- Also do a local test on benchmark: https://github.com/Yikun/spark/actions/runs/3294384181/jobs/5431945626

Closes apache#38323 from Yikun/set-output.

Authored-by: Yikun Jiang <[email protected]>
Signed-off-by: Yikun Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants