Skip to content

[SPARK-39203][SQL][FOLLOWUP] Do not qualify view location #38321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 1 commit into from
Closed

[SPARK-39203][SQL][FOLLOWUP] Do not qualify view location #38321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,12 +536,18 @@ private[hive] class HiveClientImpl(
storage = CatalogStorageFormat(
locationUri = shim.getDataLocation(h).map { loc =>
val tableUri = stringToURI(loc)
// Before SPARK-19257, created data source table does not use absolute uri.
// This makes Spark can't read these tables across HDFS clusters.
// Rewrite table location to absolute uri based on database uri to fix this issue.
val absoluteUri = Option(tableUri).filterNot(_.isAbsolute)
.map(_ => stringToURI(client.getDatabase(h.getDbName).getLocationUri))
HiveExternalCatalog.toAbsoluteURI(tableUri, absoluteUri)
if (h.getTableType == HiveTableType.VIRTUAL_VIEW) {
// Data location of SQL view is useless. Do not qualify it even if it's present, as
// it can be an invalid path.
tableUri
} else {
// Before SPARK-19257, created data source table does not use absolute uri.
// This makes Spark can't read these tables across HDFS clusters.
// Rewrite table location to absolute uri based on database uri to fix this issue.
val absoluteUri = Option(tableUri).filterNot(_.isAbsolute)
.map(_ => stringToURI(client.getDatabase(h.getDbName).getLocationUri))
HiveExternalCatalog.toAbsoluteURI(tableUri, absoluteUri)
}
},
// To avoid ClassNotFound exception, we try our best to not get the format class, but get
// the class name directly. However, for non-native tables, there is no interface to get
Expand Down