Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Oct 20, 2022

What changes were proposed in this pull request?

mypy-protobuf 3.4.0 is just released, and will break master shortly

Why are the changes needed?

to make CI happy

Does this PR introduce any user-facing change?

No

How was this patch tested?

manually check

@zhengruifeng
Copy link
Contributor Author

https://github.com/zhengruifeng/spark/actions/runs/3287636127/jobs/5417056205

after upgrade to 3.4.0, Python code gen check will break the CI

@zhengruifeng
Copy link
Contributor Author

cc @HyukjinKwon

@zhengruifeng
Copy link
Contributor Author

cc @Yikun

@zhengruifeng
Copy link
Contributor Author

@zhengruifeng
Copy link
Contributor Author

@Yikun thank you

@zhengruifeng zhengruifeng deleted the infra_ping_mypy_protobuf branch October 20, 2022 09:53
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DeZepTup pushed a commit to DeZepTup/spark-custom that referenced this pull request Oct 31, 2022
### What changes were proposed in this pull request?
[`mypy-protobuf` 3.4.0](https://pypi.org/project/mypy-protobuf/#history) is just released, and will break master shortly

### Why are the changes needed?
to make CI happy

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
manually check

Closes apache#38316 from zhengruifeng/infra_ping_mypy_protobuf.

Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?
[`mypy-protobuf` 3.4.0](https://pypi.org/project/mypy-protobuf/#history) is just released, and will break master shortly

### Why are the changes needed?
to make CI happy

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
manually check

Closes apache#38316 from zhengruifeng/infra_ping_mypy_protobuf.

Authored-by: Ruifeng Zheng <[email protected]>
Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants