-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40768][SQL] Migrate type check failures of bloom_filter_agg() onto error classes #38315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onto error classes
|
cc @MaxGekk |
|
@lvshaokang Isn't the failure related to your changes? |
|
@MaxGekk No, It seems to be unrelated, I don't know why it would lead to this, and I tried retrying CI, but it still reports an error. |
|
@HyukjinKwon @zhengruifeng @grundprinzip Should we worry about the failures #38315 (comment) or can just ignore them? |
In theory, of you merge master into your branch this should go away as current master should be in sync. |
I have merged the master branch into my branch and push it, wating the CI complete. |
|
Can one of the admins verify this patch? |
|
@MaxGekk CI run successful. Please take a look, thanks. |
|
+1, LGTM. Merging to master. |
that was due to mypy-protobuf upgrade, now the version was pined in 0643d02 |
…onto error classes ### What changes were proposed in this pull request? In the PR, I propose to use error classes in the case of type check failure in Bloom Filter Agg expressions. ### Why are the changes needed? Migration onto error classes unifies Spark SQL error messages. ### Does this PR introduce _any_ user-facing change? Yes. The PR changes user-facing error messages. ### How was this patch tested? ``` build/sbt "sql/testOnly *SQLQueryTestSuite" build/sbt "test:testOnly org.apache.spark.SparkThrowableSuite" build/sbt "test:testOnly *BloomFilterAggregateQuerySuite" ``` Closes apache#38315 from lvshaokang/SPARK-40768. Authored-by: lvshaokang <[email protected]> Signed-off-by: Max Gekk <[email protected]>
What changes were proposed in this pull request?
In the PR, I propose to use error classes in the case of type check failure in Bloom Filter Agg expressions.
Why are the changes needed?
Migration onto error classes unifies Spark SQL error messages.
Does this PR introduce any user-facing change?
Yes. The PR changes user-facing error messages.
How was this patch tested?