[MINOR][CORE][SQL] Add missing s prefix to enable string interpolation #38297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@HyukjinKwon minor changes fixing log message strings, hoping this does not require a JIRA. |
EnricoMi
changed the title
MaxGekk
approved these changes
Oct 18, 2022
MaxGekk
changed the title
Member
|
+1, LGTM. Merging to master. |
Contributor
|
found some code still missing s, e.g: |
Contributor
Author
|
And another one: Plus five more in tests. Created follow up #38307. |
HyukjinKwon
pushed a commit
to HyukjinKwon/spark
that referenced
this pull request
Oct 21, 2022
…terpolation ### What changes were proposed in this pull request? Adds missing `s` prefix to enable string interpolation. Complements apache#38297. ### Why are the changes needed? Strings will not contain substituted values but variable names. ### Does this PR introduce _any_ user-facing change? Log messages will change. ### How was this patch tested? Not tested. Closes apache#38307 from EnricoMi/branch-fix-string-interpolation-2. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Adds missing `s` prefix to enable string interpolation. ### Why are the changes needed? Strings will not contain substituted values but variable names. ### Does this PR introduce _any_ user-facing change? Log messages will change. ### How was this patch tested? Not tested. Closes apache#38297 from EnricoMi/branch-fix-string-interpolation. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Max Gekk <[email protected]>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…terpolation ### What changes were proposed in this pull request? Adds missing `s` prefix to enable string interpolation. Complements apache#38297. ### Why are the changes needed? Strings will not contain substituted values but variable names. ### Does this PR introduce _any_ user-facing change? Log messages will change. ### How was this patch tested? Not tested. Closes apache#38307 from EnricoMi/branch-fix-string-interpolation-2. Authored-by: Enrico Minack <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds missing
sprefix to enable string interpolation.Why are the changes needed?
Strings will not contain substituted values but variable names.
Does this PR introduce any user-facing change?
Log messages will change.
How was this patch tested?
Not tested.