[SPARK-40779][PS][TEST] Fix corrwith to work properly with different anchor.
#38292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI: created JIRA for re-enabling the skipped test in the future: SPARK-40827 |
HyukjinKwon
reviewed
Oct 19, 2022
HyukjinKwon
approved these changes
Oct 19, 2022
Member
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…t anchor ### What changes were proposed in this pull request? This PR proposes to disable some tests for DataFrame.corrwith since there is regression in pandas 1.5.0. We should re-enable it after fixing in future pandas release. ### Why are the changes needed? There is bug in pandas for DataFrame.corrwith for some cases, we should skip it for now. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing CI should pass Closes apache#38292 from itholic/SPARK-40779. Authored-by: itholic <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to disable some tests for DataFrame.corrwith since there is regression in pandas 1.5.0.
We should re-enable it after fixing in future pandas release.
Why are the changes needed?
There is bug in pandas for DataFrame.corrwith for some cases, we should skip it for now.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The existing CI should pass