[SPARK-40826][SS] Add additional checkpoint rename file check #38291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
itholic
reviewed
Oct 18, 2022
Contributor
itholic
left a comment
itholic
left a comment
There was a problem hiding this comment.
Looks pretty good otherwise
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Oct 18, 2022
Member
|
Are the failures related? |
Member
|
Since the first commit passed the UT, I guess it's irrelevant. |
Member
Author
|
It is not. I only add |
Member
Author
|
Verified locally these tests are passed. |
Member
Author
|
Synced up with master and try again. |
HyukjinKwon
approved these changes
Oct 19, 2022
Member
|
Ya, |
Member
|
Merged to master for Apache Spark 3.4. |
Member
Author
|
Thanks @dongjoon-hyun @HyukjinKwon @itholic |
Contributor
|
(Just curious about how you came through the case. Was the issue from underlying storage, or inconsistency of file system API? I can't imagine the scenario if the API works as contract and the underlying file system is stable, so...) |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This adds additional checkpoint rename file check. ### Why are the changes needed? We encountered an issue recently that one customer's structured streaming job failed to read delta file. The temporary file exists but it was not successfully renamed to final delta file path. We currently don't check if renamed file exists but assume it successful. As the result, failing to read delta file assumed to be committed in last batch makes re-triggering the job impossible. We should be able to do a check against checkpoint renamed file to prevent such difficulty in advance. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests. Closes apache#38291 from viirya/add_file_check. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds additional checkpoint rename file check.
Why are the changes needed?
We encountered an issue recently that one customer's structured streaming job failed to read delta file.
The temporary file exists but it was not successfully renamed to final delta file path.
We currently don't check if renamed file exists but assume it successful. As the result, failing to read delta file assumed to be committed in last batch makes re-triggering the job impossible.
We should be able to do a check against checkpoint renamed file to prevent such difficulty in advance.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.