[SPARK-40796][BUILD][FOLLOW-UP] Fix Mypy check on unused "type: ignore" #38287
Conversation
amaliujia
changed the title
python/pyspark/sql/connect/plan.py
Outdated
| measure.function.arguments.append( # type: ignore[attr-defined] | ||
| cast(Expression, exp).to_plan(session) | ||
| ) | ||
| measure.function.arguments.append(cast(Expression, exp).to_plan(session)) |
There was a problem hiding this comment.
This is formatted by the python formatter.
|
Interesting. The ignore comment was actually useful. I am confused now on how to fix that. |
|
ah I see it is now: The python code needs to be updated because of the proto change. |
amaliujia
changed the title
|
Yes. This issue is fixed. Waiting for tests passing. |
|
it seems that the CI in master works well? https://github.com/apache/spark/actions/runs/3264890886/jobs/5368154706 |
|
I don't know how this is triggered. If you check this example PR: #38275. After rebasing it started to fail on this issue. That PR only touches two lines in Right now I can only suspect that it is triggered when a PR touches |
|
The python code on Aggregate is stale anyway: they are calling non-existing fields already. |
|
Merged to master. |
### What changes were proposed in this pull request? The mypy check in master seems to be broken: <img width="676" alt="Screen Shot 2022-10-17 at 1 09 13 PM" src="https://user-images.githubusercontent.com/1938382/196273759-64372862-6caa-4a9e-b700-b665c7ff7e6c.png"> (see it on apache#38279 and apache#38275, also reproducible locally). This PR propose to remove the relevant `type: ignore` comments. ### Why are the changes needed? Fix python lint check. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38287 from amaliujia/test_python_lint. Authored-by: Rui Wang <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
3 participants
What changes were proposed in this pull request?
The mypy check in master seems to be broken:
(see it on #38279 and #38275, also reproducible locally).
This PR propose to remove the relevant
type: ignorecomments.Why are the changes needed?
Fix python lint check.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT