[SPARK-40784][SQL][TESTS] Check error classes in DDLParserSuite #38259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @MaxGekk |
amaliujia
reviewed
Oct 15, 2022
|
|
||
| private def parseException(sqlText: String): SparkThrowable = { | ||
| intercept[ParseException](parsePlan(sqlText)) | ||
| } |
Contributor
There was a problem hiding this comment.
can this function be shared with other Suites (e.g. #38265) so move this one to AnalysisTest?
Contributor
Author
There was a problem hiding this comment.
Yes, i will move it
Member
|
@panbingkun Please, don't forget about another |
Contributor
Author
Done. |
|
Can one of the admins verify this patch? |
Contributor
Author
MaxGekk
approved these changes
Oct 16, 2022
| } | ||
|
|
||
| protected def parseException(parser: String => Any)( | ||
| sqlText: String): ParseException = { |
Member
There was a problem hiding this comment.
Should be 4 spaces, see https://github.com/databricks/scala-style-guide#spacing-and-indentation
Member
|
+1, LGTM. Merging to master. |
Contributor
|
LGTM! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This PR aims to replace 'intercept' with 'Check error classes' in DDLParserSuite. include two files: A.org.apache.spark.sql.execution.command.DDLParserSuite B.org.apache.spark.sql.catalyst.parser.DDLParserSuite ### Why are the changes needed? The changes improve the error framework. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the modified test suite: ``` $ build/sbt "test:testOnly *DDLParserSuite" ``` Closes apache#38259 from panbingkun/SPARK-40784. Authored-by: panbingkun <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to replace 'intercept' with 'Check error classes' in DDLParserSuite. include two files:
A.org.apache.spark.sql.execution.command.DDLParserSuite
B.org.apache.spark.sql.catalyst.parser.DDLParserSuite
Why are the changes needed?
The changes improve the error framework.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suite: