[SPARK-40774][CONNECT] Add Sample to proto and Connect DSL #38227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @cloud-fan |
cloud-fan
approved these changes
Oct 13, 2022
connector/connect/src/main/protobuf/spark/connect/relations.proto
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Are all of these parameters required? Or are some optional?
Contributor
There was a problem hiding this comment.
are all required for the Sample query plan, but df.sample API has multiple overloads which provide default values for some parameters. Should the proto plan match query plan or DF API?
Contributor
There was a problem hiding this comment.
I think we can go with the query plan for now and if we want to introduce optional behavior it's going to be easy to do because the proto supports optionality by default.
Contributor
There was a problem hiding this comment.
Maybe one more sentence of what the sampling does?
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala
Outdated
Show resolved
Hide resolved
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
Oct 14, 2022
connector/connect/src/main/protobuf/spark/connect/relations.proto
Outdated
Show resolved
Hide resolved
Member
|
Are you good with this @grundprinzip ? |
amaliujia
force-pushed
the
support_sample
branch
from
4f3b1a6 to
33176d0
Compare
amaliujia
force-pushed
the
support_sample
branch
from
33176d0 to
a3279eb
Compare
cloud-fan
approved these changes
Oct 18, 2022
Contributor
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? 1. Add sample to proto and connect DSL. 2. Add the missing plan comparison for column alias test case. ### Why are the changes needed? Improve API coverage on the connect proto. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38227 from amaliujia/support_sample. Authored-by: Rui Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Improve API coverage on the connect proto.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT