[SPARK-40771][CORE]: Fix overflow in broadcast estimatedTotalSize log message #38224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eejbyfeldt
force-pushed
the
SPARK-40771
branch
from
69bc042 to
926a085
Compare
|
Can one of the admins verify this patch? |
srowen
approved these changes
Oct 14, 2022
Member
|
Can you try re-running the tests? it looks unrelated |
eejbyfeldt
force-pushed
the
SPARK-40771
branch
from
926a085 to
4026fef
Compare
Contributor
Author
Looks like the rerun worked. |
Member
|
Merged to master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…message ### What changes were proposed in this pull request? This avoids a int overflow in calculating estimated total size for a broadcast. The wrong value is only used in a log message but the wrong size being logged can be confusing. ### Why are the changes needed? The current log message will be incorrect for broadcast exceeding 2GiB. ### Does this PR introduce _any_ user-facing change? I fixes the log message for broadcast > 2GiB in size. ### How was this patch tested? Existing unit tests. Does spark have some way to test logging? Closes apache#38224 from eejbyfeldt/SPARK-40771. Authored-by: Emil Ejbyfeldt <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This avoids a int overflow in calculating estimated total size for a broadcast. The wrong value is only used in a log message but the wrong size being logged can be confusing.
Why are the changes needed?
The current log message will be incorrect for broadcast exceeding 2GiB.
Does this PR introduce any user-facing change?
I fixes the log message for broadcast > 2GiB in size.
How was this patch tested?
Existing unit tests. Does spark have some way to test logging?