[SPARK-40717][CONNECT] Support Column Alias in the Connect DSL #38174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @cloud-fan |
grundprinzip
reviewed
Oct 9, 2022
Contributor
There was a problem hiding this comment.
why wouldn't this be a common attribute of Expression instead?
Contributor
There was a problem hiding this comment.
Only a few places require Expression to be wrapped by an alias. I'd like to match catalyst and have an individual Alias expression.
|
Can one of the admins verify this patch? |
cloud-fan
approved these changes
Oct 10, 2022
HyukjinKwon
approved these changes
Oct 11, 2022
Contributor
|
thanks, merging to master! |
HyukjinKwon
reviewed
Oct 14, 2022
| transform(connectTestRelation.select("id".protoAttr.as("id2"))) | ||
| } | ||
| val sparkPlan = sparkTestRelation.select($"id".as("id2")) | ||
| } |
Member
There was a problem hiding this comment.
Actually this doesn't test :-). Let me make a quick followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support Column Alias in the Connect DSL (thus in Connect proto).
Why are the changes needed?
Column alias is a part of dataframe API , meanwhile we need column alias to support
withColumnetc. API.Does this PR introduce any user-facing change?
No
How was this patch tested?
UT