[SPARK-40663][SQL] Migrate execution errors onto error classes: _LEGACY_ERROR_TEMP_2226-2250 #38173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LEGACY_ERROR_TEMP_2226-2250
Contributor
Author
|
Hi, @MaxGekk Could you review this one first while I'm taking a look at other PRs since the test is passed? |
MaxGekk
approved these changes
Oct 17, 2022
MaxGekk
changed the title
Member
|
+1, LGTM. Merging to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…CY_ERROR_TEMP_2226-2250 ### What changes were proposed in this pull request? This PR proposes to migrate 25 execution errors onto temporary error classes with the prefix `_LEGACY_ERROR_TEMP_2226` to `_LEGACY_ERROR_TEMP_2250`. The error classes are prefixed with `_LEGACY_ERROR_TEMP_` indicates the dev-facing error messages, and won't be exposed to end users. ### Why are the changes needed? To speed-up the error class migration. The migration on temporary error classes allow us to analyze the errors, so we can detect the most popular error classes. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ``` $ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" $ build/sbt "test:testOnly *SQLQuerySuite" $ build/sbt -Phive-thriftserver "hive-thriftserver/testOnly org.apache.spark.sql.hive.thriftserver.ThriftServerQueryTestSuite" ``` Closes apache#38173 from itholic/SPARK-40540-2226-2250. Authored-by: itholic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
| "autoBroadcastjoinThreshold" -> SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key, | ||
| "driverMemory" -> SparkLauncher.DRIVER_MEMORY, | ||
| "analyzeTblMsg" -> analyzeTblMsg), | ||
| cause = oe).initCause(oe.getCause) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to migrate 25 execution errors onto temporary error classes with the prefix
_LEGACY_ERROR_TEMP_2226to_LEGACY_ERROR_TEMP_2250.The error classes are prefixed with
_LEGACY_ERROR_TEMP_indicates the dev-facing error messages, and won't be exposed to end users.Why are the changes needed?
To speed-up the error class migration.
The migration on temporary error classes allow us to analyze the errors, so we can detect the most popular error classes.
Does this PR introduce any user-facing change?
No
How was this patch tested?