Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Oct 6, 2022

What changes were proposed in this pull request?

This pr aims upgrade scalatest related test dependencies to 3.2.14:

  • scalatest: upgrade scalatest to 3.2.14
  • scalatestplus
    • scalacheck: upgrade to scalacheck-1-17 3.2.14.0
    • mockito: upgrade to mockito-4-6 to 3.2.14.0
    • selenium: uprade to selenium-4-4 to 3.2.14.0 and selenium-java to 4.4, htmlunit-driver to 3.64.0, htmlunit to 2.64.0

Why are the changes needed?

The release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual test:
build/sbt -Dguava.version=31.1-jre -Dspark.test.webdriver.chrome.driver=/path/to/chromedriver -Dtest.default.exclude.tags="" -Phive -Phive-thriftserver "core/testOnly org.apache.spark.deploy.history.RocksDBBackendChromeUIHistoryServerSuite"
[info] RocksDBBackendChromeUIHistoryServerSuite:
Starting ChromeDriver 105.0.5195.52 (412c95e518836d8a7d97250d62b29c2ae6a26a85-refs/branch-heads/5195@{#853}) on port 58104
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[info] - ajax rendered relative links are prefixed with uiRoot (spark.ui.proxyBase) (2 seconds, 216 milliseconds)
[info] Run completed in 7 seconds, 816 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 111 s (01:51), completed 2022-10-6 17:14:20

@github-actions github-actions bot added the BUILD label Oct 6, 2022
Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good

@LuciferYang
Copy link
Contributor Author

https://github.com/LuciferYang/spark/actions/runs/3195804964

image

seems all passed, GA not update status

@HyukjinKwon
Copy link
Member

Merged to master.

@LuciferYang
Copy link
Contributor Author

thanks @HyukjinKwon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants