Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Oct 4, 2022

What changes were proposed in this pull request?

SPARK-40490 make the test case related to YarnShuffleIntegrationSuite starts to verify the registeredExecFile reload test scenario again,so this pr add @ExtendedLevelDBTest to LevelDB relevant tests in the yarn module so that the MacOs/Apple Silicon can skip the tests through -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest.

Why are the changes needed?

According to convention, Add @ExtendedLevelDBTest to LevelDB relevant tests to make yarn module can skip these tests through -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest on MacOs/Apple Silicon.

Does this PR introduce any user-facing change?

No

How was this patch tested?

  • Pass GitHub Actions
  • Manual test on MacOs/Apple Silicon
mvn clean install -pl resource-managers/yarn -Pyarn -am -DskipTests
mvn clean install -pl resource-managers/yarn -Pyarn -Dtest.exclude.tags=org.apache.spark.tags.ExtendedLevelDBTest

Before

*** RUN ABORTED ***
  java.lang.UnsatisfiedLinkError: Could not load library. Reasons: [no leveldbjni64-1.8 in java.library.path, no leveldbjni-1.8 in java.library.path, no leveldbjni in java.library.path, /Users/yangjie01/SourceCode/git/spark-source/resource-managers/yarn/target/tmp/libleveldbjni-64-1-7057248091178764836.8: dlopen(/Users/yangjie01/SourceCode/git/spark-source/resource-managers/yarn/target/tmp/libleveldbjni-64-1-7057248091178764836.8, 1): no suitable image found.  Did find:
	/Users/yangjie01/SourceCode/git/spark-source/resource-managers/yarn/target/tmp/libleveldbjni-64-1-7057248091178764836.8: no matching architecture in universal wrapper
	/Users/yangjie01/SourceCode/git/spark-source/resource-managers/yarn/target/tmp/libleveldbjni-64-1-7057248091178764836.8: no matching architecture in universal wrapper]
  at org.fusesource.hawtjni.runtime.Library.doLoad(Library.java:182)
  at org.fusesource.hawtjni.runtime.Library.load(Library.java:140)
  at org.fusesource.leveldbjni.JniDBFactory.<clinit>(JniDBFactory.java:48)
  at org.apache.spark.network.util.LevelDBProvider.initLevelDB(LevelDBProvider.java:48)
  at org.apache.spark.network.util.DBProvider.initDB(DBProvider.java:40)
  at org.apache.spark.network.shuffle.ExternalShuffleBlockResolver.<init>(ExternalShuffleBlockResolver.java:131)
  at org.apache.spark.network.shuffle.ExternalShuffleBlockResolver.<init>(ExternalShuffleBlockResolver.java:100)
  at org.apache.spark.network.shuffle.ExternalBlockHandler.<init>(ExternalBlockHandler.java:90)
  at org.apache.spark.network.yarn.YarnShuffleService.serviceInit(YarnShuffleService.java:276)
  at org.apache.hadoop.service.AbstractService.init(AbstractService.java:164)
  ...

After

Run completed in 9 minutes, 46 seconds.
Total number of tests run: 164
Suites: completed 23, aborted 0
Tests: succeeded 164, failed 0, canceled 1, ignored 0, pending 0
All tests passed.

@github-actions github-actions bot added the YARN label Oct 4, 2022
@LuciferYang
Copy link
Contributor Author

LuciferYang commented Oct 4, 2022

cc @dongjoon-hyun @srowen @HyukjinKwon

EDIT: Since SPARK-40490 also merged into branch-3.3 and branch-3.2(3.2 not support MacOs/Apple Silicon), I think they also need similar work. I will give separate pr

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @LuciferYang .

@dongjoon-hyun
Copy link
Member

Merged to master.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@LuciferYang
Copy link
Contributor Author

thanks @dongjoon-hyun @HyukjinKwon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants